Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hydro remix algorithm #2532

Merged
merged 45 commits into from
Jan 10, 2025
Merged

New hydro remix algorithm #2532

merged 45 commits into from
Jan 10, 2025

Conversation

guilpier-code
Copy link
Contributor

No description provided.

@guilpier-code guilpier-code marked this pull request as draft December 13, 2024 09:08
BOOST_CHECK(new_H == expected_H);
BOOST_CHECK(new_D == expected_D);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que ce test est très similaire au test précédent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui, en effet, la seule chose qui change, c'est la Pmax qui est maintenant de 50 (au lieu de 40).
D'ou le titre de ce 2eme test

std::vector<double> expected_D = {20., 30., 40., 50., 60.};
BOOST_CHECK(new_H == expected_H);
BOOST_CHECK(new_D == expected_D);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lui aussi ressemble beaucoup au précédent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui, ce test est le symétrique du test hydro_increases_and_pmax_40mwh___H_is_flattened_to_mean_H_20mwh
C'est pour montrer que l'algo est lui-même symétrique

@guilpier-code guilpier-code marked this pull request as ready for review January 7, 2025 14:20
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add a new CMake target
  2. Renaming "hydro-remix-new" -> better name

src/solver/simulation/hydro-remix-new.cpp Outdated Show resolved Hide resolved
@guilpier-code
Copy link
Contributor Author

  1. Add a new CMake target
  2. Renaming "hydro-remix-new" -> better name

Done

Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small improvement suggestions #2570

Comment on lines +79 to +90
# Remix hydro algorithm
add_library(shave-peaks-by-remix-hydro)

target_sources(shave-peaks-by-remix-hydro
PRIVATE
shave-peaks-by-remix-hydro.cpp)

target_include_directories(shave-peaks-by-remix-hydro
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@flomnes flomnes merged commit 874612d into develop Jan 10, 2025
8 checks passed
@flomnes flomnes deleted the feature/new-hydro-remix branch January 10, 2025 13:06
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants