-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New hydro remix algorithm #2532
Conversation
BOOST_CHECK(new_H == expected_H); | ||
BOOST_CHECK(new_D == expected_D); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai l'impression que ce test est très similaire au test précédent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oui, en effet, la seule chose qui change, c'est la Pmax qui est maintenant de 50 (au lieu de 40).
D'ou le titre de ce 2eme test
std::vector<double> expected_D = {20., 30., 40., 50., 60.}; | ||
BOOST_CHECK(new_H == expected_H); | ||
BOOST_CHECK(new_D == expected_D); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lui aussi ressemble beaucoup au précédent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oui, ce test est le symétrique du test hydro_increases_and_pmax_40mwh___H_is_flattened_to_mean_H_20mwh
C'est pour montrer que l'algo est lui-même symétrique
…acity on remix hydro algorithm
…tial level too low
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add a new CMake target
- Renaming "hydro-remix-new" -> better name
src/solver/simulation/include/antares/solver/simulation/hydro-remix-new.h
Outdated
Show resolved
Hide resolved
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small improvement suggestions #2570
# Remix hydro algorithm | ||
add_library(shave-peaks-by-remix-hydro) | ||
|
||
target_sources(shave-peaks-by-remix-hydro | ||
PRIVATE | ||
shave-peaks-by-remix-hydro.cpp) | ||
|
||
target_include_directories(shave-peaks-by-remix-hydro | ||
PUBLIC | ||
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
No description provided.