Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve add_boost_test CMake function #2552

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Improve add_boost_test CMake function #2552

merged 1 commit into from
Jan 6, 2025
+1 −7

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Jan 2, 2025 •
edited
Loading

  • Start parsing argument from the 2nd one, ignore the 1st argument ${ARGV0} since it's reserved to the test name
  • Remove the obsolete linking to stdc++fs (no longer necessary with modern compilers/linkers)

@flomnes flomnes requested a review from payetvin January 2, 2025 10:10
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@flomnes flomnes merged commit a71f438 into develop Jan 6, 2025
9 of 10 checks passed
@flomnes flomnes deleted the fix/improve-test-function branch January 6, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonMarechal25 JasonMarechal25 JasonMarechal25 approved these changes

@payetvin payetvin Awaiting requested review from payetvin

Assignees
No one assigned
Labels
build code quality size/XS tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flomnes @JasonMarechal25