Better handling of variable bounds for BOOL variables #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet-mit
requested changes
Jan 7, 2025
| { | ||
| case Study::SystemModel::ValueType::BOOL: | ||
| { | ||
| pb.addVariable(0., 1., true, variableID); |
There was a problem hiding this comment.
the user might define lb / ub (for example ub can be a model parameter). it's only in the case where the user doesn't define lb/ub that we should us these default values. maybe set them in the Variable object model to keep this code simple?
|
This reverts commit 072dc7b.
pet-mit
requested changes
Jan 7, 2025
|
This topic is too complex to be handled without a proper spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that the user doesn't need to provide lower & upper bounds for Boolean variables.