Migrate CDT to LLVM 16.0.6 #327
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issues: Not able to export symbols from wasm - Tests Do No Run - All code compiles - Removed old submodule cdt-llvm - Created new submodule directly from llvm using tag llvm-16.0.6 - Created `cdt-llvm-extensions` - Holds cmake files and code to patch llvm, patched via cmake - Contains `clang` attribute definitions, parsing, and code generation - Contains `wasm-ld` hooks for wasm generation of ABI, Actions, and Notification - Contains `llvm` to add EosioApply and EosioSoftFloat logic - Updated cmake for external modules to reference the new llvm submodule and directory structure - Updated cdt tools to reference clang-16 in versions - Modernized cmake files under cdt/tools - Updated compiler options to use `export` in place of `only-export` - removed `stack-canary` option as it is removed from `wasm/Driver.cpp` - Updated `tools/include/eosio` migrate to `template_arguments` from `getNumArgs` - Updated `tools/include/eosio` dereferencing by adding `.str()` - Updated `tool` replacing deprecated llvm::Nome with std::nulltopt - Removed const `value_or` function that did not allow for value to mutate, keeping same func without the const value. - Consolidated to a single `static_assert`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CDT to LLVM 16.0.6
Status
Issue Tracking
#325
Changes
cdt-llvm-extensionsclangattribute definitions, parsing, and code generationwasm-ldhooks for wasm generation of ABI, Actions, and Notificationllvmto add EosioApply and EosioSoftFloat logicexportin place ofonly-exportstack-canaryoption as it is removed fromwasm/Driver.cpptools/include/eosiomigrate totemplate_argumentsfromgetNumArgstools/include/eosiodereferencing by adding.str()toolreplacing deprecated llvm::Nome with std::nulltoptvalue_orfunction that did not allow for value to mutate, keeping same func without the const value.static_assert