Add test to BookService, CategoryService, BookController and Category… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Controller Fix problem with compiler
Rommelua
suggested changes
Dec 22, 2023
…Controller Fix problem with compiler
Sanderfuck
suggested changes
Dec 24, 2023
|
|
||
| @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) | ||
| public class BookControllerTest { | ||
|
|
Comment on lines
132
to
159
| BookDto firstBook = new BookDto(); | ||
| firstBook.setId(1L); | ||
| firstBook.setTitle("First title"); | ||
| firstBook.setAuthor("First Author"); | ||
| firstBook.setPrice(BigDecimal.valueOf(9.99)); | ||
| firstBook.setIsbn("1ISBN01"); | ||
| firstBook.setDescription("description"); | ||
| firstBook.setCoverImage("coverimage"); | ||
| BookDto secondBook = new BookDto(); | ||
| secondBook.setId(2L); | ||
| secondBook.setAuthor("Second Author"); | ||
| secondBook.setTitle("Second title"); | ||
| secondBook.setPrice(BigDecimal.valueOf(19.99)); | ||
| secondBook.setIsbn("2ISBN02"); | ||
| secondBook.setDescription("description"); | ||
| secondBook.setCoverImage("coverimage"); | ||
| BookDto thirdBook = new BookDto(); | ||
| thirdBook.setId(3L); | ||
| thirdBook.setAuthor("Third Author"); | ||
| thirdBook.setTitle("Third title"); | ||
| thirdBook.setPrice(BigDecimal.valueOf(19.99)); | ||
| thirdBook.setIsbn("3ISBN03"); | ||
| thirdBook.setDescription("description"); | ||
| thirdBook.setCoverImage("coverimage"); | ||
| List<BookDto> expected = new ArrayList<>(); | ||
| expected.add(firstBook); | ||
| expected.add(secondBook); | ||
| expected.add(thirdBook); |
There was a problem hiding this comment.
Create templates of entities and reuse it in every test what you need
Comment on lines
48
to
57
| @InjectMocks | ||
| private BookServiceImpl bookService; | ||
|
|
||
| @Mock | ||
| private BookRepository bookRepository; | ||
|
|
||
| @Mock | ||
| private BookMapper bookMapper; | ||
| @Mock | ||
| private BookSpecificationBuilder bookSpecificationBuilder; |
There was a problem hiding this comment.
Manage your empty lines! Inject place after Mock
| //when | ||
| List<BookDto> bookDtos = bookService.findAll(pageable); | ||
|
|
||
| //then |
Comment on lines
+30
to
+32
| public class CategoryServiceTest { | ||
|
|
||
| private static final String VALID_NAME = "Valid name"; |
There was a problem hiding this comment.
Keep one style of empty line after naming class
|
Fix your checks!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Controller