Chat Rich Text Filtering and Unit Tests #147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutumnThyme
reviewed
Sep 28, 2024
Assets/Scripts/Scripts.asmdef
Outdated
| "GUID:49818357e697641afb75d2f8acaf1861", | ||
| "GUID:b8c9b6a82a342504c8e4a2747471d23c", | ||
| "GUID:02f771204943f4a40949438e873e3eff", | ||
| "GUID:0acc523941302664db1f4e527237feb3", |
There was a problem hiding this comment.
What's with all these asmdef file changes?
There was a problem hiding this comment.
Oh, I didn't realize you could see my drafts on github. This contains the changes from the assembly definitions branch. I'll merge that branch first so this diff disappears. Please ignore.
|
Also, when adding this, please also add this when a user set's their name/after the bracket color format is transformed into all rich text tags as people end up breaking stuff by mixing together both rich text and the color tags. |
|
What's the status on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents invalid tags from breaking the rich text rendering:
Input text:
Current rendering behavior:
Behavior with new filtering enhancement:
Unit tests:
