fix: contract type collision issues from deleted files and empty file issues #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/empty-contracts-infinite-compile
branch
from
36d4b86 to
ca6d8b8
Compare
antazoey
changed the title
antazoey
changed the title
fubuloubu
previously approved these changes
Jan 5, 2024
antazoey
force-pushed
the
fix/empty-contracts-infinite-compile
branch
3 times, most recently
from
4876117 to
e61ed6d
Compare
antazoey
force-pushed
the
fix/empty-contracts-infinite-compile
branch
from
7d87aee to
7f61f5d
Compare
|
was previously approved and all i did was fight caplog into submitting to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #1780
How I did it
only add trailing \n if not empty
How to verify it
compile an empty contract more than once and see what happens
Checklist