update v3 #3
Open
update v3 #3
+65
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froodian
reviewed
Mar 30, 2017
| sleep_time = params[:api_key][6..-1].to_i | ||
| sleep sleep_time | ||
| end | ||
| # if params[:api_key].starts_with?("sleep_") |
froodian
reviewed
Mar 30, 2017
| puts " " | ||
| body_read = request.body.read | ||
| # puts "headers" | ||
| # puts JSON.pretty_generate(request.env) |
There was a problem hiding this comment.
can we remove or uncomment this?
froodian
reviewed
Mar 30, 2017
| @@ -37,11 +40,62 @@ def halt_with_error(error, response_body) | |||
| "the stub api is up!" | |||
| end | |||
|
|
|||
| post '/v3/data/' do | |||
| post '/api/v2/data/?' do | |||
| puts " " | |||
There was a problem hiding this comment.
can we use logger instead of puts statements?
There was a problem hiding this comment.
(or are the behaviorally different for some reason?)
froodian
reviewed
Mar 30, 2017
| puts " " | ||
| puts " " | ||
| body_read = request.body.read | ||
| # puts "headers" |
There was a problem hiding this comment.
same note about commented out logging here
froodian
reviewed
Mar 30, 2017
| @@ -97,6 +151,7 @@ def halt_with_error(error, response_body) | |||
| end | |||
|
|
|||
| if !params[:attributes].nil? | |||
| attributes_object = params[:attributes] | |||
There was a problem hiding this comment.
this line appears to be irrelevant/cruft?
|
done looking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.