Skip to content

Commit

Permalink
fix dataframe call to only ignore including apps in report if all row…
Browse files Browse the repository at this point in the history
… values are NaN (#143)
  • Loading branch information
alexafshar authored May 7, 2024
1 parent 56d14c2 commit 655114e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion backend/output/presentations/cxPptFsoUseCases.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def __init__(self, directory: str, filenames: tuple):
self.workbooks[filename] = pd.read_excel(full_path, sheet_name=None)
except Exception as e:
logging.warning(f"Not able to load workbook {filename}")
logging.warning(f"Was it generated to begin with? Ignoring.")
logging.warning(f"Was it generated to begin with? Ignoring. "
f"Continuing with the rest of the workbooks.")

def findSheetByHeader(self, header_name):
result = []
Expand Down
5 changes: 3 additions & 2 deletions backend/output/reports/ConfigurationAnalysisReport.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async def post_process(self, jobFileName):
applicationData.append([application, ranking, []])

self.buildOutput(applicationData, worksheets)
logging.debug(f"Saving ConfigurationAnalysisReport Workbook")
logging.info(f"Saving ConfigurationAnalysisReport Workbook")
self.workbook.close()

def getValuesInColumn(self, sheet, col1_value):
Expand All @@ -65,7 +65,8 @@ def getValuesInColumn(self, sheet, col1_value):
return values

def getListOfApplications(self):
frame = pd.read_excel(self.analysis_sheet, sheet_name='Analysis', engine='openpyxl').dropna()
frame = pd.read_excel(self.analysis_sheet, sheet_name='Analysis',
engine='openpyxl').dropna(how='all')
return frame['name'].tolist()

def overallAppStatus(self, application, tasklist):
Expand Down

0 comments on commit 655114e

Please sign in to comment.