Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js): Add tool call id to semantic conventions and parse via instrumentation #1105

Merged
merged 5 commits into from
Nov 8, 2024
Merged

feat(js): Add tool call id to semantic conventions and parse via instrumentation #1105

merged 5 commits into from
Nov 8, 2024

Conversation

cephalization
Copy link
Contributor

@cephalization cephalization commented Nov 7, 2024 •
edited
Loading

  • Extend semantic conventions js
    • message.tool_call_id
    • message.tool_calls.index.tool_call.id
  • Extend ai semantic conventions js
  • Parse tool call IDs via instrumentation
    • openai
    • langchain will create new issue
    • vercel

@cephalization cephalization force-pushed the cephalization/5195-capture-tool-ids-js-instrumentation branch from 5cc8700 to efd2de9 Compare November 7, 2024 16:06
@cephalization cephalization mentioned this pull request Nov 7, 2024
Closed
@cephalization cephalization marked this pull request as ready for review November 7, 2024 17:24
@cephalization cephalization requested a review from a team as a code owner November 7, 2024 17:24
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@cephalization cephalization merged commit a0e6f30 into main Nov 8, 2024
3 checks passed
@cephalization cephalization deleted the cephalization/5195-capture-tool-ids-js-instrumentation branch November 8, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parker-Stafford Parker-Stafford Parker-Stafford approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cephalization @Parker-Stafford