Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): set spans from instrumentation active span on context in OpenAI instrumentor #1121

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix(js): set spans from instrumentation active span on context in OpenAI instrumentor #1121

merged 5 commits into from
Nov 14, 2024

Conversation

Parker-Stafford
Copy link
Contributor

resolves #1061

  • spans created as apart of the work instrumented in the OpenAIInstrumetation will now be properly nested under those spans, for example http instrumentation see:

image

@Parker-Stafford Parker-Stafford requested a review from a team as a code owner November 14, 2024 01:10
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 14, 2024
@Parker-Stafford Parker-Stafford mentioned this pull request Nov 14, 2024
Open
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 14, 2024
@Parker-Stafford Parker-Stafford mentioned this pull request Nov 14, 2024
Closed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@codefromthecrypt
Copy link

looking forward to helping q/a this once released!

@Parker-Stafford
Copy link
Contributor Author

looking forward to helping q/a this once released!

Awesome, have another fix to get in then should be releasing soon!

@Parker-Stafford Parker-Stafford merged commit 47cd6b5 into main Nov 14, 2024
3 checks passed
@Parker-Stafford Parker-Stafford deleted the parker/1103-fix-trace-propagation branch November 14, 2024 16:32
@codefromthecrypt
Copy link

sorry for the very late Q/A, this works now!

Screenshot 2025-01-18 at 7 58 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cephalization cephalization cephalization approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] JS example with HttpInstrumentation
3 participants
@Parker-Stafford @codefromthecrypt @cephalization