feat(js): add session id parsing to langchain instrumentation #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parses metadata with key name in (session_id, thread_id, conversation_id) into semantic conventions session id
dosubot
bot
added
the
size:L
cephalization
commented
Dec 5, 2024
Comment on lines
+4
to
+28
| import { HumanMessage } from "@langchain/core/messages"; | ||
|
|
||
| const main = async () => { | ||
| const chatModel = new ChatOpenAI({ | ||
| openAIApiKey: process.env.OPENAI_API_KEY, | ||
| metadata: { | ||
| session_id: "test-session-123", | ||
| }, | ||
| }); | ||
|
|
||
| const response = await chatModel.invoke("Hello! How are you?"); | ||
| const request = new HumanMessage("Hello! How are you?"); | ||
|
|
||
| const response = await chatModel.invoke([request]); | ||
|
|
||
| // get a new response, including a greeting in the message history | ||
| const finalResponse = await chatModel.invoke([ | ||
| request, | ||
| response, | ||
| new HumanMessage("That is great to hear!"), | ||
| ]); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log(response.content); | ||
| console.log(finalResponse.content); | ||
|
|
||
| return response; | ||
| return finalResponse; |
There was a problem hiding this comment.
Happy to revert these changes if they seem too complex for generic example code
mikeldking
approved these changes
Dec 5, 2024
js/packages/openinference-instrumentation-langchain/src/utils.ts
Outdated
Show resolved
Hide resolved
cephalization
deleted the
cephalization/js/5085-langchain-thread-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses metadata with key name in (session_id, thread_id, conversation_id) into semantic conventions session id