Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js): Update quick start dependency list #1162

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

cephalization
Copy link
Contributor

Typescript does not like the omission of @opentelemetry/instrumentation from our list of suggested otel sdk deps.

Installing it manually removes type errors in our sample instrumentation code further down in this document.

@cephalization cephalization requested a review from a team as a code owner December 8, 2024 16:32
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 8, 2024
Typescript does not like the omission of `@opentelemetry/instrumentation` from our list of suggested otel sdk deps.

Installing it manually removes type errors in our sample instrumentation code further down in this document.
@cephalization cephalization force-pushed the cephalization/js/update-readme-deps branch from d506d3a to 7937d7f Compare December 8, 2024 16:33
@cephalization cephalization merged commit 81cb963 into main Dec 8, 2024
3 checks passed
@cephalization cephalization deleted the cephalization/js/update-readme-deps branch December 8, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants