Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(llama-index): coerce token counts to be integers #1183

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(llama-index): coerce token counts to be integers #1183

merged 1 commit into from
Jan 9, 2025

Conversation

RogerHYang
Copy link
Contributor

Sometimes they're strings.

Screenshot 2025-01-09 at 11 59 58 AM

@RogerHYang RogerHYang requested a review from a team as a code owner January 9, 2025 20:02
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 9, 2025
@RogerHYang RogerHYang merged commit 3af6ca6 into main Jan 9, 2025
3 checks passed
@RogerHYang RogerHYang deleted the coerce-token-counts-to-be-integers branch January 9, 2025 20:30
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cephalization cephalization cephalization approved these changes

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RogerHYang @cephalization