Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update openinference-vercel semantic convention mapping for output #1203

Merged
merged 2 commits into from
Jan 18, 2025
+25 −20
Merged

fix: Update openinference-vercel semantic convention mapping for output #1203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a4a26f
Update AISemanticConventions.ts result prefix
luke-moehlenbrock Jan 15, 2025
d944a82
Changed 'result' to 'response' throughout package
luke-moehlenbrock Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/packages/openinference-vercel/src/AISemanticConventions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const AIPrefixes = {
telemetry: "telemetry",
prompt: "prompt",
toolCall: "toolCall",
result: "result",
result: "response",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result: "response",
response: "response",

Shouldn't this be the case here? @Parker-Stafford

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah for consistency lets do that, then you'll want to change these
https://github.com/Arize-ai/openinference/blob/main/js/packages/openinference-vercel/src/AISemanticConventions.ts#L53-L60
to response as well and key off AIPrefixes.response

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and these
https://github.com/Arize-ai/openinference/blob/main/js/packages/openinference-vercel/src/utils.ts#L460-L471

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions @Parker-Stafford and @mikeldking! I went through and changed result to response throughout the package

} as const;

const AIUsagePostfixes = {
Expand Down
Loading