Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove token on crewai kickoff chain span #1213

Merged
merged 12 commits into from
Jan 17, 2025
Merged

Conversation

nate-mar
Copy link
Contributor

Resolves #1154

@nate-mar nate-mar requested a review from a team as a code owner January 17, 2025 03:19
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
Update test_instrumentor.py

Update test_instrumentor.py

Update tox.ini

Update tox.ini

Update tox.ini

Update tox.ini

Update tox.ini

Update tox.ini

Update tox.ini

Update tox.ini

Update test_instrumentor.py

Revert "Update test_instrumentor.py"

This reverts commit 9427e74.
@nate-mar nate-mar force-pushed the remove-token-on-kickoff branch from 9427e74 to a050cfa Compare January 17, 2025 08:26
@@ -74,7 +74,7 @@ commands_pre =
guardrails: uv pip install -r test-requirements.txt
guardrails-latest: uv pip install -U 'guardrails-ai<0.5.1' 'httpx<0.28'
crewai: uv pip install --reinstall {toxinidir}/instrumentation/openinference-instrumentation-crewai[test]
crewai-latest: uv pip install -U crewai 'httpx<0.28'
crewai-latest: uv pip install -U 'crewai==0.55.2' 'httpx<0.28'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works up to 0.55.2 -- running with this for now and will come back to fix it for versions after this.

@nate-mar nate-mar merged commit f015bca into main Jan 17, 2025
3 checks passed
@nate-mar nate-mar deleted the remove-token-on-kickoff branch January 17, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug] crewAI kikoff spans incorrectly contain token counts
2 participants