-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove token on crewai kickoff chain span #1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Jan 17, 2025
mikeldking
approved these changes
Jan 17, 2025
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Jan 17, 2025
Update test_instrumentor.py Update test_instrumentor.py Update tox.ini Update tox.ini Update tox.ini Update tox.ini Update tox.ini Update tox.ini Update tox.ini Update tox.ini Update test_instrumentor.py Revert "Update test_instrumentor.py" This reverts commit 9427e74.
nate-mar
force-pushed
the
remove-token-on-kickoff
branch
from
January 17, 2025 08:26
9427e74
to
a050cfa
Compare
nate-mar
commented
Jan 17, 2025
@@ -74,7 +74,7 @@ commands_pre = | |||
guardrails: uv pip install -r test-requirements.txt | |||
guardrails-latest: uv pip install -U 'guardrails-ai<0.5.1' 'httpx<0.28' | |||
crewai: uv pip install --reinstall {toxinidir}/instrumentation/openinference-instrumentation-crewai[test] | |||
crewai-latest: uv pip install -U crewai 'httpx<0.28' | |||
crewai-latest: uv pip install -U 'crewai==0.55.2' 'httpx<0.28' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works up to 0.55.2 -- running with this for now and will come back to fix it for versions after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1154