Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aisf b3 tweaks #1034

Open
wants to merge 1 commit into
base: aisf
Choose a base branch
from
Open

aisf b3 tweaks #1034

wants to merge 1 commit into from
+39 −28

Conversation

yurique
Copy link
Contributor

@yurique yurique commented Jan 10, 2025

No description provided.

@Jon-b-m
Copy link
Member

Jon-b-m commented Jan 12, 2025

Please wait and review the code in next big update instead. I’ve refactored some part of autoisf

@Jon-b-m
Copy link
Member

Jon-b-m commented Jan 13, 2025

The only change we needed is this:

let settings = storage.retrieve(OpenAPS.Settings.settings, as: PumpSettings.self)
?? PumpSettings(from: OpenAPS.defaults(for: OpenAPS.Settings.settings))
?? PumpSettings(insulinActionCurve: 6, maxBolus: 10, maxBasal: 2)

If you could remove the rest from your PR please?

@Jon-b-m Jon-b-m added the question Further information is requested label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
iAPS Development Board
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurique @Jon-b-m