Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: paths, encoding for files and preparation for the new setup #37

Merged
merged 13 commits into from
Jul 26, 2024
Merged

Fix: paths, encoding for files and preparation for the new setup #37

merged 13 commits into from
Jul 26, 2024

Conversation

Artprozew
Copy link
Owner

@Artprozew Artprozew commented Jul 26, 2024 •
edited
Loading

This PR introduces:

Fixes:

  • Encoding exceptions, UTF-8 will now be used, while also ignoring possible encoding errors on the log file.
  • Add/Improve validations for the config.ini paths.
  • Character with skins will now be displayed correctly.
  • Wrong/missing character data (Childe and Sigewinne, Kirara and Nilou skins). Ayaka skin will still be missing for now.

Added

  • As a preparation for the new setup, the program can now apply the settings from a backup_config.ini file to the config.ini file, if that backup file exists.

Artprozew added 12 commits July 22, 2024 23:46
@Artprozew
refactor: add validation for the ini path
793f7e1
@Artprozew
fix: use utf-8 and ignore log encoding errors
c02ee7b
@Artprozew
chore: update missing/wrong character data hashes
acfc68a
@Artprozew
refactor: change ini encoding to UTF-16
12d0b61 
the encoding for the config.ini file will now be UTF-16-LE with BOM.
this is done so the new installer setup can work with it correctly.
@Artprozew
fix: exception_handler encoding and error ignores
2b72b46
@Artprozew
refactor: get_environ_or_ini(), add new parameter
e0ac83e
@Artprozew
refactor: add method to apply config backups
0987235
@Artprozew
refactor: minor update to logger exit message
0a262a8
@Artprozew
refactor: update gimi_dir and game_process values
97f10f7
@Artprozew
refactor: use backup applier method on startup
964aa0b
@Artprozew
chore: change config.ini encoding and defaults
8396085 
change the default values, organize the file, change encoding to
UTF-16-LE
@Artprozew
chore: remove ayaka skin hash
904cff1 
as I'm not sure if the hash is correct, it will be removed for now.
@Artprozew Artprozew self-assigned this Jul 26, 2024
@Artprozew Artprozew added bug Something isn't working enhancement New feature or request labels Jul 26, 2024
@Artprozew
refactor: ignore essential setting on backup apply
c4e0b90 
this is done so those settings from the new config.ini file that the
setup created will take precedence instead.
@Artprozew Artprozew merged commit 20b57ab into master Jul 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Artprozew Artprozew

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Artprozew