Revert errors.go changes and update RPC links on .yml files

AryanGodara · May 28, 2024 · 7dab635 · 7dab635
1 parent a58841e
commit 7dab635
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/main_ci_check.yml b/.github/workflows/main_ci_check.yml
@@ -44,15 +44,15 @@ jobs:
         #run: cd rpc && go test -timeout 1200s -v -env testnet .
         env:
           TESTNET_ACCOUNT_PRIVATE_KEY: ${{ secrets.TESTNET_ACCOUNT_PRIVATE_KEY }}
-          INTEGRATION_BASE: "https://starknet-goerli.cartridge.gg/"
+          INTEGRATION_BASE: "https://free-rpc.nethermind.io/sepolia-juno"
 
       # Test rpc on mainnet
       - name: Test RPC with mainnet
         run: echo "Skip for now - need public endpoint that follows rpc spec"
         #run: cd rpc && go test -timeout 600s -v -env mainnet .
         env:
           TESTNET_ACCOUNT_PRIVATE_KEY: ${{ secrets.TESTNET_ACCOUNT_PRIVATE_KEY }}
-          INTEGRATION_BASE: "https://starknet.cartridge.gg/"
+          INTEGRATION_BASE: "https://free-rpc.nethermind.io/mainnet-juno"
 
       # Test Account on devnet
       - name: Test Account on devnet

diff --git a/.github/workflows/test_rpc.yml b/.github/workflows/test_rpc.yml
@@ -46,12 +46,12 @@ jobs:
         #run: cd rpc && go test -timeout 1200s -v -env testnet .
         env:
           TESTNET_ACCOUNT_PRIVATE_KEY: ${{ secrets.TESTNET_ACCOUNT_PRIVATE_KEY }}
-          INTEGRATION_BASE: "https://starknet-goerli.cartridge.gg/"
+          INTEGRATION_BASE: "https://free-rpc.nethermind.io/sepolia-juno"
 
       # Test rpc on mainnet
       - name: Test RPC with mainnet
         run: echo "Skip for now - need public endpoint that follows rpc spec"
         #run: cd rpc && go test -timeout 600s -v -env mainnet .
         env:
           TESTNET_ACCOUNT_PRIVATE_KEY: ${{ secrets.TESTNET_ACCOUNT_PRIVATE_KEY }}
-          INTEGRATION_BASE: "https://starknet.cartridge.gg/"
+          INTEGRATION_BASE: "https://free-rpc.nethermind.io/mainnet-juno"
diff --git a/rpc/errors.go b/rpc/errors.go
@@ -3,7 +3,6 @@ package rpc
 import (
 	"encoding/json"
 	"errors"
-	"fmt"
 )
 
 var ErrNotImplemented = errors.New("not implemented")
@@ -64,7 +63,6 @@ func tryUnwrapToRPCErr(err error, rpcErrors ...*RPCError) *RPCError {
 			return &nodeErr
 		}
 	}
-
 	return Err(InternalError, err.Error())
 }
 
@@ -75,10 +73,6 @@ type RPCError struct {
 }
 
 func (e RPCError) Error() string {
-	if _, ok := e.Data.(string); !ok {
-		return fmt.Sprintf("%s: %v", e.Message, e.Data)
-	}
-
 	return e.Message
 }