Update to Asbuilt report to run on pure storage SDK2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated version to work with pure storade SDK 2 and newer pure storage API calls.
fixed formatting
Added checks for //File on pure flash arrays. Fixed up Network speed calculation Partially tested and configured SNMP traps output
Still outstanding issues with Host Groups Fixed outstanding issues with volume configuration and protection groups
fixed spelling in host group config still not working as intended
Fixed Directory Service Groups output
Cleaned up formatting in SSL Certificate and System Summary Resolved issues with Host Groups not working correctly.
added in new changes
date update
updated to SDK2
Added Disk protocol
added known issues
formatting
formatting
formatting
formatting
added known issue
formatting
formatting
updated slaves to Sub Interfaces in Network Configuration and fixed functionality
|
An amazing work! 👏 |
|
Any chance of getting this code merged? I have access to a Pure environment and would like to test this also have some friends who can contribute to this report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is to uplift the code used in the AsBuiltReport.PureStorage.FlashArray to work with Pure's new SDK2 Module leveraging their new API
Related Issue
#16
Motivation and Context
Change was required due to the forced obsolescence of the SDK1 commands in purity OS 6.4.X
It was also found that running the existing version on purity OS 6.3.X showed more and more errors over time
How Has This Been Tested?
Test detail
Script has been tested on Purity OS 6.4.10, 6.3.7, 6.3.10, 6.3.12 with and without //file enabled with no issues.
Each change to the existing script was done by walking down the entire Array and updating the command to SDK2 and then subsequently updating the section associated with the updated array command.
After these updates where completed the script was run to ensure formatting and information matched an existing script's output.
Due to the changes in SDK2 from SDK1 a lot of rework was required due to the movement of functionality in the API
All aspects of the Script has been tested due to the entire script being re-factored to support SDK2
Testing Environment
multiple Pure sans and differing levels of code from 6.3.7 up to 6.4.10
Script was tested on lower environments first to gauge functionality then ran against differing versions of the purity OS in a production environment.
Change Effects
As this was a complete re-write to allow SDK2 functionality it has dramatically changed the entire code base
Screenshots (if appropriate):
Types of changes
Checklist: