Refactor of RYScaffold to use TopAppBar with scrolling behaviour #873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor of the RYScaffold to use a TopAppBar with nested scrolling instead of an in-content header.
This also moves the Switch Account action from being on the Feeds page header text on-click to an actual dedicated button. I think this is more discoverable b/c it is not obvious how to switch accounts from the Feeds page if you don't already know about this feature.
Jump to top is also preserved for the browsing pages via an on-click callback on RYScaffold's new TopAppBar. This is basically what it was before, just move around a little.
Note that there is some goofyness around pages that are smaller that the viewport. Ideally I'd like them to not be scrollable at all but, I was not able to figure out how to do that elegantly. I could always pass down a boolean flag to RYScaffold to turn the scrolling off but, that feels nasty. If you have any ideas, let me know.
Before
After