-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack): add Harper #1199
feat(pack): add Harper #1199
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
a0420ce
to
69a057d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! This should be a language pack that goes in lua/astrocommunity/pack/harper.lua
since it configures multiple plugins at once time and also is not providing a new plugin.
69a057d
to
c711b7b
Compare
@mehalter, moved! I understand that you try to mean |
harper-ls
integrationharper-ls
integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! Only thing is it should be pack/harper
and not pack/harper-ls
harper-ls
integrationc711b7b
to
165a3b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and fixed it to get this merged. Thanks again!
📑 Description
Add
harper-ls
integration, aLSP
to interop with Harper.ℹ Additional Information
From it's website: