Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add Harper #1199

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

cristobalgvera
Copy link
Contributor

📑 Description

Add harper-ls integration, a LSP to interop with Harper.

ℹ Additional Information

From it's website:

Harper is an English grammar checker designed to be just right. You can think of it as an open-source alternative to Grammarly.

Copy link

github-actions bot commented Sep 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@cristobalgvera cristobalgvera force-pushed the feature/add-harper-ls branch 4 times, most recently from a0420ce to 69a057d Compare September 13, 2024 03:33
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This should be a language pack that goes in lua/astrocommunity/pack/harper.lua since it configures multiple plugins at once time and also is not providing a new plugin.

mehalter

This comment was marked as duplicate.

@cristobalgvera
Copy link
Contributor Author

cristobalgvera commented Sep 13, 2024

Thanks for the contribution! This should be a language pack that goes in lua/astrocommunity/pack/harper.lua since it configures multiple plugins at once time and also is not providing a new plugin.

@mehalter, moved!

I understand that you try to mean lua/astrocommunity/pack/harper-ls instead of .../harper.lua, am I right?

@cristobalgvera cristobalgvera changed the title feat(utility): add harper-ls integration feat(pack): add harper-ls integration Sep 13, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Only thing is it should be pack/harper and not pack/harper-ls

@mehalter mehalter changed the title feat(pack): add harper-ls integration feat(pack): add Harper Sep 16, 2024
@mehalter mehalter force-pushed the feature/add-harper-ls branch from c711b7b to 165a3b1 Compare September 16, 2024 00:26
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and fixed it to get this merged. Thanks again!

@mehalter mehalter merged commit 84ecff9 into AstroNvim:main Sep 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants