Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avante-nvim): update correct plug mappings #1210

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix(avante-nvim): update correct plug mappings #1210

merged 2 commits into from
Sep 16, 2024

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Sep 15, 2024

📑 Description

Avante will now provide Plug mapping instead of commands for some functionalities to avoid poluting namespace from users.

Avante will now provide Plug mapping instead of commands for some functionalities to avoid poluting namespace from users.
Copy link

github-actions bot commented Sep 15, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@aarnphm aarnphm changed the title chore(avante): update correct plug mappings fix(avante-nvim): update correct plug mappings Sep 15, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great, made one comment to help out

Co-authored-by: Micah Halter <micah@mehalter.com>
@aarnphm aarnphm requested a review from mehalter September 16, 2024 00:16
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mehalter mehalter merged commit 6f7ecaf into AstroNvim:main Sep 16, 2024
15 checks passed
@aarnphm aarnphm deleted the patch-1 branch September 16, 2024 13:37
SunJun8 added a commit to SunJun8/NvimConfig that referenced this pull request Sep 23, 2024
Signed-off-by: SunJ <jsun@bouffalolab.com>
SunJun8 added a commit to SunJun8/NvimConfig that referenced this pull request Nov 8, 2024
Signed-off-by: SunJ <jsun@bouffalolab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants