Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mini-indentscope): add animation #1216

Conversation

fynnfluegge
Copy link
Contributor

📑 Description

Adds an animation to mini-indentscope with faster border rendering. Personally the slow rendering is very distracting to my eyes. Raising a PR since it feels this distraction is a common perception.

ℹ Additional Information

Before

ezgif-5-af0f5dddd8

After

ezgif-5-343c8f0050

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@fynnfluegge fynnfluegge changed the title chore(mini-indentscope): add animation fix(mini-indentscope): add animation Sep 21, 2024
@luxus
Copy link
Member

luxus commented Sep 22, 2024

we normally stick to the default.
u always can overwrite the setting for yourself locally.
i guess it would be unexpected have different defaults

@fynnfluegge
Copy link
Contributor Author

Alright, thought this would be a better default. Closing it, thanks for the response!

@luxus
Copy link
Member

luxus commented Sep 23, 2024

it makes more sense to ask upstream to change the default.. but i guess mini will not change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants