-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hugeicons and update to new theme colors #4911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosvik
force-pushed
the
rosvik/theme-upgrade
branch
from
January 13, 2025 12:00
a7919a3
to
3ef758e
Compare
rosvik
changed the title
feat: upgrade theme package
feat: add hugeicons and update to new theme colors
Jan 13, 2025
rosvik
force-pushed
the
rosvik/theme-upgrade
branch
from
January 14, 2025 08:28
852ae23
to
20f0828
Compare
This value and VIPPS_BACKGROUND_COLOR should maybe be part of the design system, but since the background is hard coded, it makes sense to have the text color hard coded as well.
rosvik
requested review from
gorandalum,
marius-at-atb,
jorelosorio and
strandlie
as code owners
January 15, 2025 09:46
rosvik
force-pushed
the
rosvik/theme-upgrade
branch
from
January 15, 2025 09:48
6f86c9b
to
a66ba93
Compare
reidzeibel
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small step
for manin terms of code changes, but a hugeiconleap formankindthe OMS ✨transport.shuttle
color fortransportSubMode: "shuttleBus"
(VM colors for AtB)closes https://github.com/AtB-AS/kundevendt/issues/19401
closes https://github.com/AtB-AS/kundevendt/issues/19098
closes https://github.com/AtB-AS/kundevendt/issues/19586