fix: Adhere limitations in tariff zone selector #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we no longer need to pass around multiple purchase related fields when navigating between purchase screens. I wasn't able to split this up more than this since as soon as the route param was changed all of these places needed to be fixed.
When there is limitation on multiple tariff zones for a product, the user is able to navigate to the tariff zone selection map. But in that map all zones were actually shown, not just the one applicable by the limitation.
Base automatically changed from
dalum/purchase_selection_in_route_params
to
master
January 14, 2025 12:38
gorandalum
requested review from
marius-at-atb,
jorelosorio,
rosvik and
strandlie
as code owners
rosvik
approved these changes
Jan 14, 2025
|
✅ By editing the referenceData. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is limitation on multiple tariff zones for a product, the
user is able to navigate to the tariff zone selection map. But in
that map all zones were actually shown, not just the one applicable
by the limitation.
Acceptance criteria
How to test:
preassignedFareProduct.limitations.tariffZoneRefs