Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: able to use map area between buttons #4921

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jorunnl
Copy link
Contributor

@jorunnl jorunnl commented Jan 13, 2025

In the map tab:

The bug is that users are not able to use area at the bottom of the screen between the buttons (area marked with red on the screenshot).
The user can not press buttons (for example bus stops) in the area or use the area to move the map.

This is now fixed.

image

Acceptance Criteria

  • user can click on button (bus stop or bike stand) at the bottom of the map
  • user can start moving the map at the bottom of the map
  • Buttons over map (star, location, filter) are present and function as before
    • Star in bottom left when isBonusProgramEnabled is true (this button does nothing)
    • Filter and location in bottom right, with filter above location

Test input

  • 200% Zoom
  • Light and Dark mode
  • Language

Copy link
Contributor

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
To make life easy for testers, you can also add a section with Acceptance Criteria in the PR ;)

src/components/map/hooks/use-control-styles.ts Outdated Show resolved Hide resolved
@jorunnl jorunnl merged commit 0c85c8a into master Jan 14, 2025
4 checks passed
@jorunnl jorunnl deleted the jorunn/fix-bug-map-area-between-buttons branch January 14, 2025 09:36
@hanne-at-atb
Copy link
Contributor

Tested ok. Thank you for good test-input @jorunnl 🌟

@hanne-at-atb
Copy link
Contributor

Opsi, I see now that the button for my position on the map in travel search has moved out of its original place. So that should be fixed @jorunnl
This is if you make a travel search -> choose a travel -> enter the map (at the bottom) OR click the follow bus button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants