ui - improve self review member approval #2849
Conversation
ArtjomsPorss
changed the title
ArtjomsPorss
force-pushed
the
self-serve-review
branch
from
5db870e to
2233425
Compare
There was a problem hiding this comment.
adding comment from offline conversation:
-
instead of using getRoles and getGroups to get details of all roles/groups in a domain, it would be better to do a getRole/Group call for specific collection which have a pending member
-
It will also be useful to check if the role/group data is already present in store, if not then make API call to get role/group and then store it in redux store.
will make changes to cover both points |
|
@chandrasekhar1996 |
ArtjomsPorss
force-pushed
the
self-serve-review
branch
2 times, most recently
from
d7624d3 to
a3a1681
Compare
…oles and grops Signed-off-by: aporss <art.porss@yahooinc.com>
ArtjomsPorss
force-pushed
the
self-serve-review
branch
from
a3a1681 to
44d413a
Compare
|
|
||
| const getPendingMemberRole = async (dispatch, state, domainName, roleName) => { | ||
| let role = selectPendingMemberRole(state, domainName, roleName); | ||
| if (!role || isExpired(role.expiry)) { | ||
| role = await API().getRole(domainName, roleName, false, false, true); | ||
| role.expiry = getExpiryTime(); | ||
| dispatch(storePendingRole(role, domainName, roleName)); | ||
| } | ||
| return role; | ||
| }; | ||
| const getPendingMemberGroup = async ( | ||
| dispatch, | ||
| state, | ||
| domainName, | ||
| groupName | ||
| ) => { | ||
| let group = selectPendingMemberGroup(state, domainName, groupName); | ||
| if (!group || isExpired(group.expiry)) { | ||
| group = await API().getGroup(domainName, groupName, false, true); | ||
| group.expiry = getExpiryTime(); | ||
| dispatch(storePendingGroup(group, domainName, groupName)); | ||
| } |
There was a problem hiding this comment.
@chandrasekhar1996 this part covers selecting specific role/group data from state, if not present or expired - get role/group and store in state for later
| if (category === ROLE) { | ||
| promises.push(getPendingMemberRole(dispatch, state, domain, role)); | ||
| } else if (category === GROUP) { | ||
| promises.push(getPendingMemberGroup(dispatch, state, domain, role)); | ||
| } | ||
| }); | ||
|
|
||
| let data = await Promise.all(promises); |
There was a problem hiding this comment.
getting unique roles/groups for selfReview check is done in parallel
Description
use member comment to auto populate justification textarea when approving self review roles and groups
Contribution Checklist: