Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Winback] Link row to Help & Feedback #2469

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Winback] Link row to Help & Feedback #2469

merged 2 commits into from
Nov 21, 2024

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2435

Fixes #2440

This PR linked the Help & Feedback screen to the specific row

RocketSim_Recording_iPhone_16_6.1_2024-11-20_18.07.01.mp4

To test

  • CI must be 🟢
  • Make sure the winback FF is on
  • Use a Plus/Patron user
  • Go to Account -> Cancel Subscription
  • Tap on the Need help with Pocket Casts? row
  • Confirm the Help & Feedback view is pushed into the nav stack

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.78 milestone Nov 20, 2024
@danielebogo danielebogo requested a review from a team as a code owner November 20, 2024 19:44
@danielebogo danielebogo requested review from SergioEstevao and removed request for a team November 20, 2024 19:44
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.78. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

SergioEstevao
SergioEstevao approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iPhone and iPad and all good.
:shipit:

Base automatically changed from danieleb/Winback/2437-build-middle-screen to trunk November 21, 2024 15:18
@danielebogo danielebogo merged commit ce26211 into trunk Nov 21, 2024
5 of 8 checks passed
@danielebogo danielebogo deleted the danieleb/Winback/2440-link-to-help branch November 21, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Project] Winback
Projects
None yet
Milestone
7.78
Development

Successfully merging this pull request may close these issues.

[Winback] Link button to Help page
3 participants
@danielebogo @dangermattic @SergioEstevao