-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Winback] Apply Apple API for subscription cancellation #2474
[Winback] Apply Apple API for subscription cancellation #2474
Conversation
Generated by 🚫 Danger |
@@ -25,7 +26,29 @@ class CancelConfirmationViewModel: OnboardingModel { | |||
Analytics.track(.cancelConfirmationCancelButtonTapped) | |||
|
|||
if FeatureFlag.winback.enabled { | |||
//TODO: Add Apple API | |||
Task { | |||
guard let windowScene = await navigationController.view.window?.windowScene else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this code to be refactored to a separated function that could part of IAPHelper in order to better contain any StoreKit code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergioEstevao I part of it to the IAPHandler
. All the part related to the groupID and StoreKit, so now everything is well decoupled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise is working correctly, just asked for a code change.
Daniele Bogo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the suggestion!
Fixes #2444
Fixes #2445
This PR uses the
StorerKit.AppStore
API to present the subscriptions panel and handle thoseTo test
winback
FFChecklist
CHANGELOG.md
if necessary.