Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hack Week] Downloads sort #2504

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

[Hack Week] Downloads sort #2504

wants to merge 4 commits into from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Dec 4, 2024

Adds sorting options to Downloads including a new file size sort.
Simulator Screenshot - iPhone 16 - 2024-12-04 at 11 39 28 Simulator Screenshot - iPhone 16 - 2024-12-04 at 11 39 31 Simulator Screenshot - iPhone 16 - 2024-12-04 at 11 51 54

To test

  • Download several episodes
  • Open the Profiles > Downloads screen
  • Tap the Ellipse
  • Change the "Sort By" menu option

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added this to the 7.79 milestone Dec 4, 2024
@bjtitus bjtitus requested a review from a team as a code owner December 4, 2024 19:15
@bjtitus bjtitus requested review from leandroalonso and removed request for a team December 4, 2024 19:15
@dangermattic
Copy link
Collaborator

1 Error
🚫 PR requires at least one label.

Generated by 🚫 Danger

@bjtitus bjtitus removed the request for review from leandroalonso December 4, 2024 19:16
@bjtitus bjtitus marked this pull request as draft December 4, 2024 19:16
@bjtitus bjtitus added Needs design This issues needs design input [Type] Enhancement Improve an existing feature. labels Dec 4, 2024
@CookieyedCodes
Copy link

Could we also have a sort by podcast option:)

@SergioEstevao SergioEstevao modified the milestones: 7.79, 7.80 Dec 9, 2024
@SergioEstevao
Copy link
Contributor

Version 7.79 has now entered code-freeze, so the milestone of this PR has been updated to 7.80.

@danielebogo danielebogo modified the milestones: 7.80, 7.81 Jan 6, 2025
@danielebogo
Copy link
Contributor

Version 7.80 has now entered code-freeze, so the milestone of this PR has been updated to 7.81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs design This issues needs design input [Type] Enhancement Improve an existing feature.
Projects
None yet
Milestone
7.81
Development

Successfully merging this pull request may close these issues.
5 participants
@bjtitus @dangermattic @CookieyedCodes @SergioEstevao @danielebogo