-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the use of the AutoDownloadStatus enums #2506
Open
SergioEstevao
wants to merge
7
commits into
trunk
Choose a base branch
from
hack/enum_refactor
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the enum directly on the model type and avoid the uses of raw value and casting in the codebase. I also found that FMDatabase can support the use of Enum directly on their statements if they are a base type. Ex: Int32, Int, etc..
SergioEstevao
requested review from
danielebogo
and removed request for
a team
December 9, 2024 10:04
Version |
Version |
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: # |
|:---:|
Fixes #
On this PR we use the enum directly on the model type and avoid the uses of raw value and casting in the codebase. I also found that FMDatabase can support the use of Enum directly on their statements if they are a base type. Ex: Int32, Int, etc..
One of the things that was blocking it was that our base episode protocol was marked as ObjC. I thought there was some reason for the use of
@objc
tag on the protocols, but after removal I didn't get any kind of error.If someone knows the reason why those protocols are marked @objc please comment bellow.
To test
Checklist
CHANGELOG.md
if necessary.