Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Winback] Filter view based on client #2561

Merged

Conversation

danielebogo
Copy link
Contributor

📘 Part of: #2435

Fixes #2507

Shows the new Cancel Subscription screen only if the subscription platform is iOS. For all other platforms we will display the current web view.

1 2 3
RocketSim_Screenshot_iPhone_16_6 1_2024-12-17_14 32 23 RocketSim_Screenshot_iPhone_16_6 1_2024-12-17_14 34 47 RocketSim_Screenshot_iPhone_16_6 1_2024-12-17_14 34 51

To test

  • CI must be 🟢
  • Make sure you have what winback FF on
  • Login with a premium user where the subscription is from another platform (Android/Web)
  • Go to Account -> Cancel Subscription
  • You should see the legacy screen
  • Tapping on

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@danielebogo danielebogo added this to the 7.80 milestone Dec 17, 2024
@danielebogo danielebogo requested a review from a team as a code owner December 17, 2024 14:39
@danielebogo danielebogo requested review from bjtitus and removed request for a team December 17, 2024 14:39
Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Everything worked well!

One thing I wonder is whether we could change the "Show me how" link to go directly to the platform:

Android https://support.pocketcasts.com/knowledge-base/how-to-cancel-a-subscription/#htoc-google-play-store
Web https://support.pocketcasts.com/knowledge-base/how-to-cancel-a-subscription/#htoc-pocket-casts-website

@danielebogo danielebogo merged commit 4d6fae5 into trunk Dec 18, 2024
5 of 8 checks passed
@danielebogo danielebogo deleted the danieleb/Winback-2445/2507-filter-view-based-on-platform branch December 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Winback] Filter new screen based on plan purchased client
2 participants