Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Clips] Add Associated Domains to App Clips #2625

Open
wants to merge 1 commit into
base: danieleb/app-clips/base-branch
Choose a base branch
from

Conversation

danielebogo
Copy link
Contributor

πŸ“˜ Part of: #2549

Part of #2551

Based on Apple Documentation, we need to add and specify the Associated Domains to both the App and App Clips targets.

This PR adds:
β€’ appclips:pocketcasts.com to the App entitlement
β€’ appclips:pca.st, appclips:pcast.pocketcasts.net, appclips:pocketcasts.com to the AppClips entitlement

To test

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mokagio
Copy link
Contributor

mokagio commented Jan 10, 2025

I added the associated domains capability to the App Clip on the developer portal and regenerated the provisioning profiles.

On my end, Xcode shows no warnings in the Signing & Capabilities tag for the target

image

Notice the associated domains capability in the distribution provisioning profile.

@danielebogo danielebogo marked this pull request as ready for review January 11, 2025 13:04
@danielebogo danielebogo requested a review from a team as a code owner January 11, 2025 13:04
@danielebogo danielebogo linked an issue Jan 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project: App Clip
2 participants