Skip to content

Commit

Permalink
[Tooling] Update GitHub Actions (#1718)
Browse files Browse the repository at this point in the history
  • Loading branch information
iangmaia authored Dec 13, 2024
2 parents f924b88 + a3a00bd commit c946759
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ agents:
steps:
- label: ":gradle: Gradle Wrapper Validation"
command: validate_gradle_wrapper
plugins: [$CI_TOOLKIT_PLUGIN]
agents:
queue: linter
notify:
- github_commit_status:
context: Gradle Wrapper Validation
Expand Down
5 changes: 4 additions & 1 deletion .buildkite/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ agents:
queue: android

steps:
# NOTE: once this pipeline is called inline from another pipeline via ReleasesV2,
# we may need to use another agent to checkout the release branch before the Gradle Wrapper Validation
- label: ":gradle: Gradle Wrapper Validation"
command: validate_gradle_wrapper
priority: 1
plugins: [$CI_TOOLKIT_PLUGIN]
agents:
queue: linter

- wait

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gradle-wrapper-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ jobs:
name: "Validation"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: gradle/wrapper-validation-action@v1
- uses: actions/checkout@v4
- uses: gradle/actions/wrapper-validation@v4
4 changes: 2 additions & 2 deletions tools/extract_release_notes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def replace_pr_link_with_markdown_link(string)
case mode
when :strip_pr_links
formatted_lines = release_lines
.map { |l| l.gsub(/ \[.*\]$/, '') }
.map { |l| l.gsub(/ \[.*\]$/, '') }
when :keep_pr_links
# The PR "links" are not canonical markdown links. That's not a problem on
# GitHub where they be automatically parsed into links to the corresponding
Expand All @@ -72,7 +72,7 @@ def replace_pr_link_with_markdown_link(string)
# It's probably best to update the convention in writing the release notes
# but in the meantime let's compensate with more automation.
formatted_lines = release_lines
.map { |l| replace_pr_link_with_markdown_link(l) }
.map { |l| replace_pr_link_with_markdown_link(l) }
end

# It would be good to either add overriding of the file where the parsed
Expand Down

0 comments on commit c946759

Please sign in to comment.