Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Pass header content to Stream components #98045

Merged
merged 22 commits into from
Jan 10, 2025

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Jan 7, 2025

Related to https://github.com/Automattic/loop/issues/296

Proposed Changes

  • Pass user profile header and navigation from UserStream component to both UserPosts and UserLists components as children
  • Add children prop to UserPosts and UserLists components to accept header content
  • Refactor UserStream to extract header content into a shared variable

Why are these changes being made?

Testing Instructions

  • Assuming the infinite API loop is fixed with this change Reader: Check for missing pageHandle in lastPage stream reducer #98046
  • Using Calypso Live go to /read/users/218803706
  • You should be able to see the W icon at the bottom of the Stream signifying there are no more posts
  • Go to /read/users/132828356 to view profile with no posts. The W icon should not be visible.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 7, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug loop-269/pass-header-content-to-stream-components on your sandbox.

@DustyReagan DustyReagan self-assigned this Jan 7, 2025
@DustyReagan DustyReagan marked this pull request as ready for review January 7, 2025 22:57
@DustyReagan DustyReagan requested a review from a team as a code owner January 7, 2025 22:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 7, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~55 bytes added 📈 [gzipped])

name                                   parsed_size           gzip_size
async-load-calypso-reader-user-stream       +247 B  (+6.3%)      +55 B  (+3.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Base automatically changed from loop-269/add-empty-states-of-user-profile-screens to trunk January 8, 2025 06:18
client/reader/user-stream/views/lists.tsx Outdated Show resolved Hide resolved
client/reader/user-stream/views/posts.tsx Outdated Show resolved Hide resolved
client/reader/user-stream/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@mehmoodak mehmoodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made following minor changes in the PR:

  • 0800fac - Improve spacing and remove extra properties which we don't want now due to change of the structure.

  • 9256ed9 - Move header styles to its dedicated file

@DustyReagan DustyReagan merged commit bde75ca into trunk Jan 10, 2025
11 checks passed
@DustyReagan DustyReagan deleted the loop-269/pass-header-content-to-stream-components branch January 10, 2025 16:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants