Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listTasks should return the majority of task data instead of just id and status #28

Closed
chrisli30 opened this issue Nov 5, 2024 · 1 comment
Labels
enhancement New feature or request P1 Priority 1

Comments

@chrisli30
Copy link
Member

chrisli30 commented Nov 5, 2024

There would be many subsequent calls if we need to fetch eash task after getting a list. The listTasks() endpoint should already return the most important data for each task.

  1. According to the below design we would at least need to return Id, creator(SmartAccountAddress), startAt, expiredAt and status fields.
  2. No need to return the eoa wallet address as owner, since we can find it out at the applicate level. Let’s return the direct owner, which is the smart wallet address.
  3. @v9n, for simplicity I suggest we return the entire task data in listTasks for now, and trim the response later, when request load increases.

CleanShot 2024-11-05 at 01 22 14@2x

Task Definition:
https://github.com/AvaProtocol/ava-sdk-js/blob/main/src/task.ts

@chrisli30 chrisli30 added enhancement New feature or request P1 Priority 1 labels Nov 5, 2024
@v9n
Copy link
Member

v9n commented Nov 21, 2024

Fixed in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Priority 1
Projects
None yet
Development

No branches or pull requests

2 participants