Implement actual AVS functionality #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
reviewed
Nov 15, 2024
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
@chrisli30 ready to review again |
chrisli30
previously approved these changes
Nov 21, 2024
.github/workflows/run-test-on-pr.yml
Outdated
| run: | | ||
| npm test | ||
|
|
||
| local-test: |
There was a problem hiding this comment.
oh, nice, github workflow could already build a docker and test this in action servers?
Then, my suggestion is to separate the tests into two workflows. That way the staging test failure would not affect the local test run.
package.json
Outdated
| @@ -22,9 +22,10 @@ | |||
| "node": ">=20.18.0" | |||
| }, | |||
| "scripts": { | |||
| "proto-download": "curl -s https://raw.githubusercontent.com/AvaProtocol/EigenLayer-AVS/main/protobuf/avs.proto > grpc_codegen/avs.proto", | |||
| "proto-download": "curl -s https://raw.githubusercontent.com/AvaProtocol/EigenLayer-AVS/new-task-data-structure/protobuf/avs.proto > grpc_codegen/avs.proto", | |||
There was a problem hiding this comment.
maybe we should revert this line?
chrisli30
force-pushed
the
update-client-for-phase2-task-structure
branch
from
924a64c to
173a81b
Compare
Removed dist folder and old instructions from README after local testing
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement actual task creation.
Fixed #4 #5 #11 #15 #16 #17 #28