This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
Feature/#815- Filter database datanodes should not read all data #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Cov
Overall Coverage
New FilesNo new covered files... Modified Files
|
jrobinAV
reviewed
Nov 7, 2023
src/taipy/core/data/data_node.py
Outdated
| @@ -441,6 +440,10 @@ def __getitem__(self, item): | |||
| def _read(self): | |||
| raise NotImplementedError | |||
|
|
|||
| @abstractmethod | |||
| def _read_by(self, operators: Union[List, Tuple], join_operator=JoinOperator.AND): | |||
There was a problem hiding this comment.
Why don't you override the filter method directly instead of going through a _read_by method that is eventually not implemented?
It is possible to override the filter method in MongoCollectionDataNode and not in CsvDataNode, for instance.
There was a problem hiding this comment.
The reason is that I completely forgot 🤣
jrobinAV
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#815