TextLayout: TextStyleOverrides aren't applied correctly #17922
+33
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures that all TextStyleOverrides are applied correctly.
What is the current behavior?
Currently, the first TextRun is generated too long.
For example, we have the following text
... and TextStyleOverrides to highlight the first two "He" at the beginning of each line:
-> the first TextRun is generated too long:
What is the updated/expected behavior with this PR?
The first TextRun has the expected length:
How was the solution implemented (if it's not obvious)?
The FormattedTextSource->CreateTextStyleRun method was iterating through all the TextStyleOverrides (TextModifiers) and applying them to the TextRun until the last one was in scope. I changed it to apply the first TextStyleOverride in scope to the TextRun and return it immediately, as it makes no sense to apply more than one override to one TextRun? This makes the hasOverride flag obsolete.