Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG representation for Linear Vesting #210

Merged
merged 15 commits into from
Jul 8, 2024
Merged

SVG representation for Linear Vesting #210

merged 15 commits into from
Jul 8, 2024

Conversation

0xJem
Copy link
Contributor

@0xJem 0xJem commented Jun 21, 2024

Completes #168

@0xJem
Copy link
Contributor Author

0xJem commented Jun 21, 2024

@Oighty I noticed that you branched off master. Should we rebase off develop instead?

src/modules/derivatives/LinearVestingCard.sol Outdated Show resolved Hide resolved
}

// ========== EXAMPLE ========== //
// Used by hot-chain-svg during development. TODO: Remove for prod.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove redundant code

utils/hot-chain-svg/package.json Outdated Show resolved Hide resolved
src/modules/derivatives/LinearVestingCard.sol Outdated Show resolved Hide resolved
src/modules/derivatives/LinearVesting.sol Outdated Show resolved Hide resolved
src/modules/derivatives/LinearVesting.sol Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I would fix the linter warnings, so the style is consistent.

@0xJem
Copy link
Contributor Author

0xJem commented Jun 26, 2024

@Oighty should I merge after reviewing? (and fixing the tests - probably salts)

@Oighty
Copy link
Contributor

Oighty commented Jul 5, 2024

@Oighty should I merge after reviewing? (and fixing the tests - probably salts)

Yes, this should be good now once the CI is fixed.

@Oighty Oighty changed the base branch from master to develop July 8, 2024 17:48
@Oighty Oighty merged commit 5c6c617 into develop Jul 8, 2024
1 check passed
@Oighty Oighty deleted the liv-svg branch July 8, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants