Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Deployment Addresses #220

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Improvements to Deployment Addresses #220

merged 6 commits into from
Jul 11, 2024

Conversation

0xJem
Copy link
Contributor

@0xJem 0xJem commented Jul 11, 2024

  • Removes redundant deployment addresses for atomic contracts.
  • Splits env.json to have separate keys for constants and deployments. Updates all deployment and salt scripts to use the new keys.
    • I've tested this on an Arb Sepolia fork with the origin/batch callbacks and uniswap DTL sequences, and it reads and writes deployments correctly.
  • Updates the allowlist salts script to use the named arguments format used in other scripts.

@0xJem 0xJem self-assigned this Jul 11, 2024
@0xJem 0xJem requested a review from Oighty July 11, 2024 09:39
Oighty
Oighty approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Oighty Oighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Oighty Oighty merged commit 4171e11 into develop Jul 11, 2024
1 check passed
@Oighty Oighty deleted the env-cleanup branch July 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oighty Oighty Oighty approved these changes

Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xJem @Oighty