Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hmmorales/update sample sdk code for 2021-11-01-preview #23

Merged

Conversation

hmmorales
Copy link
Collaborator

@hmmorales hmmorales commented Apr 7, 2022

Updating all sample code to demonstrate several networking properties and functionality

go/main.go Outdated Show resolved Hide resolved
go/main.go Outdated Show resolved Hide resolved
go/main.go Outdated Show resolved Hide resolved
go/main.go Outdated Show resolved Hide resolved
@poanchen
Copy link
Collaborator

LGTM

@poanchen
Copy link
Collaborator

@hmmorales there is another PR still active, let's take what we think makes sense there into your PR and close it or simply just close it.

@hmmorales hmmorales changed the title Hmmorales/update sample go sdk Hmmorales/update sample sdk code Apr 20, 2022
nodejs/index.ts Outdated Show resolved Hide resolved
nodejs/index.ts Outdated Show resolved Hide resolved
@poanchen
Copy link
Collaborator

Once those minor spacing is fixed, we should be good. Overall, it looks good!

@hmmorales hmmorales closed this Apr 22, 2022
@hmmorales hmmorales reopened this Apr 22, 2022
@hmmorales hmmorales changed the title Hmmorales/update sample sdk code Hmmorales/update sample sdk code for 2021-11-01-preview Apr 25, 2022
@hmmorales hmmorales merged commit c543c88 into Azure-Samples:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants