-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: frontend components refactoring #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfibiacreativa
force-pushed
the
chore/frontend-components-refactoring
branch
from
November 10, 2023 13:37
def9608
to
b930278
Compare
shibbas
force-pushed
the
chore/frontend-components-refactoring
branch
from
November 11, 2023 00:39
2c78d29
to
1d4b9c5
Compare
shibbas
force-pushed
the
chore/frontend-components-refactoring
branch
from
November 16, 2023 06:11
857e470
to
9493991
Compare
LGTM! Approved. |
Merging since @anfibiacreativa approved my changes to this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactors the frontend chat-component lit-element into several smaller lit-elements that can be used independently or removed as needed. Cleans direct DOM access as well as uses more reactive properties and state. citation previewer now supports sandbox iframe for other reference types.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information