Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: frontend components refactoring #108

Merged
merged 41 commits into from
Nov 16, 2023

Conversation

anfibiacreativa
Copy link
Member

@anfibiacreativa anfibiacreativa commented Nov 3, 2023

Purpose

Refactors the frontend chat-component lit-element into several smaller lit-elements that can be used independently or removed as needed. Cleans direct DOM access as well as uses more reactive properties and state. citation previewer now supports sandbox iframe for other reference types.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code
npm run test:playwright

What to Check

Verify that the following are valid

  • ...

Other Information

@anfibiacreativa anfibiacreativa force-pushed the chore/frontend-components-refactoring branch from def9608 to b930278 Compare November 10, 2023 13:37
@shibbas shibbas force-pushed the chore/frontend-components-refactoring branch from 2c78d29 to 1d4b9c5 Compare November 11, 2023 00:39
@shibbas shibbas force-pushed the chore/frontend-components-refactoring branch from 857e470 to 9493991 Compare November 16, 2023 06:11
@shibbas shibbas changed the base branch from main to develop November 16, 2023 06:12
@shibbas shibbas marked this pull request as ready for review November 16, 2023 06:15
@anfibiacreativa
Copy link
Member Author

LGTM! Approved.

@shibbas
Copy link
Contributor

shibbas commented Nov 16, 2023

Merging since @anfibiacreativa approved my changes to this branch.

@shibbas shibbas merged commit dfcd3be into develop Nov 16, 2023
1 check passed
@anfibiacreativa anfibiacreativa deleted the chore/frontend-components-refactoring branch January 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants