Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll to last message #110

Merged
merged 14 commits into from
Nov 6, 2023
Merged

fix: scroll to last message #110

merged 14 commits into from
Nov 6, 2023

Conversation

anfibiacreativa
Copy link
Member

@anfibiacreativa anfibiacreativa commented Nov 4, 2023

Purpose

Scroll to bottom of chat list when the messages update

  • ...

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

Submit a question. Chat auto scrolls smoothly and the chat form doesn't overlap

What to Check

Performance is not degraded since event is debounced.
perf
perf1

@anfibiacreativa anfibiacreativa marked this pull request as ready for review November 4, 2023 21:31
@sinedied sinedied merged commit a127a29 into main Nov 6, 2023
5 checks passed
@sinedied sinedied deleted the fix/scroll-to-last-message branch November 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants