fix(indexer): incorrect path on Windows (#141) #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yohan Lasorsa <noda@free.fr>
|
Please @sinedied target 'develop' until tomorrow evening. |
anfibiacreativa
approved these changes
Nov 16, 2023
manekinekko
reviewed
Nov 19, 2023
Comment on lines
-3
to
+5
| import { execSync } from 'node:child_process'; | ||
| import { run } from '../dist/lib/cli.js'; | ||
|
|
||
| if ((process.env.NODE_OPTIONS ?? '').includes('--no-warnings')) { | ||
| run(process.argv); | ||
| } else { | ||
| // Silence experimental warnings | ||
| try { | ||
| execSync(process.argv.join(' '), { | ||
| stdio: 'inherit', | ||
| env: { | ||
| ...process.env, | ||
| NODE_OPTIONS: `${process.env.NODE_OPTIONS ?? ''} --no-warnings`, | ||
| }, | ||
| }); | ||
| } catch { | ||
| // Do nothing | ||
| } | ||
| } | ||
| run(process.argv); |
There was a problem hiding this comment.
I am confused. What's the fix here?
There was a problem hiding this comment.
Removed code was only to silence warnings, but on Windows it introduces a path issue because of exec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes path issues on Windows.
A warning due to using experimental feature in Node 18 will be displayed at runtime though, but does not impact the result.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?