Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(indexer): add PDF ingestion support #149

Merged
merged 4 commits into from
Dec 12, 2023
Merged

feat(indexer): add PDF ingestion support #149

merged 4 commits into from
Dec 12, 2023

Conversation

sinedied
Copy link
Contributor

Purpose

I'll update the PR when develop is merged into main to avoid conflicts, hence the draft PR

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@sinedied sinedied marked this pull request as ready for review December 4, 2023 15:37
shibbas
shibbas approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@shibbas shibbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to move the setup of the handlers outside the processor

@sinedied sinedied merged commit 081659a into main Dec 12, 2023
6 checks passed
@sinedied sinedied deleted the indexer-pdf branch December 12, 2023 08:23
@sinedied sinedied mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anfibiacreativa anfibiacreativa anfibiacreativa left review comments

@shibbas shibbas shibbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinedied @anfibiacreativa @shibbas