Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new chat protocol extension points #170

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

sinedied
Copy link
Contributor

Purpose

Update chat protocol data points structure to match Python sample's updated implementation, following their support of GPT4-V: Azure-Samples/azure-search-openai-demo@3601589

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Copy link
Member

@anfibiacreativa anfibiacreativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sinedied I am getting a 500 error on testing this PR on codespaces, that doesn't happen on main. Please retest.

@sinedied
Copy link
Contributor Author

sinedied commented Feb 5, 2024

@anfibiacreativa I just redeployed the branch from codespaces, everything works fine on my side.

Could this be merged so we have compatibility with Python backend for today's stream?

@anfibiacreativa anfibiacreativa merged commit 1d9fcd3 into main Feb 13, 2024
6 checks passed
@sinedied sinedied deleted the protocol-update branch February 29, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants