chore: update docker dependencies #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfibiacreativa
approved these changes
Feb 12, 2024
sinedied
reviewed
Feb 12, 2024
.devcontainer/devcontainer.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| "ghcr.io/devcontainers/features/node:1": { | |||
| "version": "18" | |||
| }, | |||
| "ghcr.io/devcontainers/features/docker-in-docker:1": { | |||
| "ghcr.io/devcontainers/features/docker-in-docker:2.9.0": { | |||
There was a problem hiding this comment.
We should just use 2 as the feature version to get updates and fixes, and the "version": 20 below can be removed as the docker buildx issues has been fixed now
| @@ -11,7 +11,7 @@ | |||
| "ghcr.io/devcontainers/features/node:1": { | |||
| "version": "18" | |||
| }, | |||
| "ghcr.io/devcontainers/features/docker-in-docker:2.9.0": { | |||
| "ghcr.io/devcontainers/features/docker-in-docker:2": { | |||
There was a problem hiding this comment.
@sinedied can you please approve?
sinedied
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Opening a local version of the repo causes issues with using the docker daemon. This version of docker does not cause conflicts.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information