-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the selected approach to the chat component and to the api call #188
Conversation
@JasonHaley please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
It seems the Playwright tests are failing, could you check that it works for you? It may need an update with your fix. # once
npm run install:playwright
npm run test:playwright |
I'll take a look at it this afternoon and let you know. |
@sinedied I think the problem was line 25 in OneShot.tsx needs to be:
I ran the tests and that seems to fix most of them, but there are still 2 unrelated ones failing on my machine, which I'm guessing is some configuration on my system. |
Thanks, that's perfect :) |
This issue is for a: (mark with an
x
)Minimal steps to reproduce
The ask-read-retrieve-read is the approach that uses the Dynamic Tool.
You can try changing the approach in the Developer Settings, but it does not seem to work.
Also the OneShot.tsx file does have the rrr hard-coded.
Expected/desired behavior